[DOCS] Clarify max_shingle_size parm def#53480
[DOCS] Clarify max_shingle_size parm def#53480jrodewig merged 2 commits intoelastic:masterfrom jrodewig:docs__clarify_max_shingle_size
max_shingle_size parm def#53480Conversation
jrodewig
added
>docs
|
Pinging @elastic/es-docs (>docs) |
|
Pinging @elastic/es-search (:Search/Mapping) |
Rewrites the `search_as_you_type` field datatype's `max_shingle_size` mapping parameter to improve clarity and better communicate trade-offs regarding index size. Relates to [elastic/kibana#55161][0]. [0]: elastic/kibana#55161 (comment)
cjcenizal
left a comment
cjcenizal
left a comment
There was a problem hiding this comment.
Thanks for making this change! I had one small request.
| A subfield is created for each integer between `2` and this value. For example, | ||
| a value of `3` creates two subfields: `my_field._2gram` and `my_field._3gram` | ||
|
|
||
| More subfields enable more specific queries but increase index size. |
There was a problem hiding this comment.
I have no idea whether the correct grammar is "more subfields enable" or "more subfields enables", but the UI copy is already shipped, so for consistency can we change on "more subfields enables"?
There was a problem hiding this comment.
I think it should be plural ("enable") as "subfields" is also plural, but I can change this for consistency. Don't think it'll prevent anyone from understanding.
There was a problem hiding this comment.
I raised elastic/kibana#60088 to get this fixed in UI copy. I'll update here once that's in.
Thanks again @cjcenizal!
Rewrites the `search_as_you_type` field datatype's `max_shingle_size` mapping parameter to improve clarity and better communicate trade-offs regarding index size. Relates to [elastic/kibana#55161][0]. Closes #51774. [0]: elastic/kibana#55161 (comment)
Rewrites the `search_as_you_type` field datatype's `max_shingle_size` mapping parameter to improve clarity and better communicate trade-offs regarding index size. Relates to [elastic/kibana#55161][0]. Closes #51774. [0]: elastic/kibana#55161 (comment)
sebelga
left a comment
sebelga
left a comment
There was a problem hiding this comment.
LGTM! Thanks for making the update
5 participants
Rewrites the
search_as_you_typefield datatype'smax_shingle_sizemapping parameter to improve clarityand better communicate trade-offs regarding index size.
Relates to elastic/kibana#55161.
Closes #51774